This repository has been archived by the owner on May 11, 2022. It is now read-only.
Bug fix #7
Open
Bug fix #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed magneticHeading declaration and initialization
|
Anyone? |
| @@ -135,8 +135,12 @@ public void onSensorChanged(SensorEvent event) { | |||
| // Convert the heading (which is relative to magnetic north) to one that is | |||
| // relative to true north, using the user's current location to compute this. | |||
| float magneticHeading = (float) Math.toDegrees(mOrientation[0]); | |||
| mHeading = MathUtils.mod(computeTrueNorth(magneticHeading), 360.0f) | |||
| - ARM_DISPLACEMENT_DEGREES; | |||
| mHeading = MathUtils.mod(computeTrueNorth(magneticHeading), 360.0f) - ARM_DISPLACEMENT_DEGREES; | |||
There was a problem hiding this comment.
Using this should do the trick instead of the test block below:
mHeading = MathUtils.mod(computeTrueNorht(magneticHeading) - ARM_DISPLACEMENT_DEGREES, 360.0f);
Also, please make sure to follow Android's coding style standard:
https://source.android.com/source/code-style.html
Specifically, use spaces instead of tabs and keep the lines below 100 characters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where mHeading's range was (-6, 354) instead of (0, 360)